Fix GHSA-82j2-j2ch-gfr8: remove rustls-webpki <0.103.13 (DoS via malformed CRL)#62
Merged
Merged
Conversation
aws-sdk-ssm's default features enabled a legacy rustls 0.21 TLS stack alongside the modern rustls 0.23 stack. Disabling that redundant legacy feature removes rustls-webpki <0.103.13 from the dependency tree entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws-sdk-ssm's default features pulled in a redundant legacy TLS stack (rustls 0.21→rustls-webpki 0.101.7) alongside the already-present modern stack (rustls 0.23)rustlsdefault feature onaws-sdk-ssmremoves the entire legacy stack;default-https-client+rt-tokioretain full functionality via rustls 0.23What changed
Cargo.toml— one line:Cargo.lock— removesrustls 0.21.12,rustls-webpki 0.101.7,hyper 0.14.32,hyper-rustls 0.24.2,tokio-rustls 0.24.1,sct, and legacysocket2/h2versions. Smaller binary as a side effect.Test plan
cargo buildsucceedscargo tree -i rustls-webpki@0.101.7returns no match (package no longer present)